Light Calorimetry: add sim energy deposit info and light calo info into cafs #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2025
Contributor
|
@lynnt20 could you nominate reviewers please? |
sbncode v10_14_02 for larsoft v10_14_02
linyan-w
moved this from Expected for Later
to Waiting on Reviewer
in SBND 2025 Fall Production
Contributor
Author
|
@PetrilloAtWork would you mind taking a look at this PR? It's the last of the light calorimetry stack of PRs 😃 Thank you advance! |
sbncode v10_14_02_01 for larsoft v10_14_02_01
henrylay97
reviewed
Jan 30, 2026
Member
henrylay97
left a comment
henrylay97
left a comment
There was a problem hiding this comment.
Looking really good. Couple of small queries before I approve :D
henrylay97
approved these changes
Feb 3, 2026
7 tasks
|
@PetrilloAtWork: when you have a moment, could you review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds info from
SimEnergyDepositsand light calorimetry into cafmaker.SBND is currently keeping
SimEnergyDepositsthroughout the workflow. We can take better advantage of this information (truth level number of electrons, photons, and true energy deposits for true neutrino interactions) by adding it to the cafs in a new class calledSRTrueDeposit. Default will be empty if noSimEnergyDeposits are available in the input files. Only adds 3 floats per neutrino interaction (obtained from length ofMCTruth).Accompanying PRs: SBNSoftware/sbndcode#878, SBNSoftware/sbnanaobj#181, SBNSoftware/sbnobj#158